node-chromedriver icon indicating copy to clipboard operation
node-chromedriver copied to clipboard

Allow to provide custom writeable stream for logs

Open christian-bromann opened this issue 4 years ago • 3 comments

It would be great if users could pass in a custom writeable stream to direct Chromedriver logs to a dedicated location.

christian-bromann avatar May 18 '21 08:05 christian-bromann

Chromedriver is a binary executable not a Node.js script, and this package does not control it, it only allows you to install it and start the process. I'm not sure this idea is feasible. How do you see it being implemented?

giggio avatar May 18 '21 20:05 giggio

Sorry for not being clear enough. Currently starting the Chromedriver process programatically only allows to pipe the stdout/stderr into the process stdout/stderr. It would be great if some option arguments could be passed in that would allow to control this better, e.g. make this piping optional, create spawn process first, then wait for for the port to open so we can attach to the process stdout in between. I've been successfully working around this.

christian-bromann avatar May 18 '21 20:05 christian-bromann

Ok, that makes sense. A PR is welcome but it must not break the existing api.

giggio avatar May 20 '21 22:05 giggio