ember-animate icon indicating copy to clipboard operation
ember-animate copied to clipboard

reopening every view may not be a good idea

Open stefanpenner opened this issue 9 years ago • 4 comments

consider a subclass, or flag. We likely shouldn't subject every view to this extra functionality and weight.

stefanpenner avatar Mar 10 '15 18:03 stefanpenner

See https://github.com/gigafied/ember-animate/issues/17

I could probably refactor it some, maybe even having checks for the view type in ContainerView so that normal views work too. I just don't have time at the moment. I'll leave this issue open.

Probably the best way to do this would be to use some sort of flag on EmberENV.

EmberENV.EMBER_ANIMATE_EXTEND_VIEWS = true;

That way I can expose Ember.AnimatedView, Ember.AnimatedContainerView and {{animated-outlet}} if that flag is set to false.

gigafied avatar Mar 10 '15 23:03 gigafied

Is there a particular issue you ran into because of this, or that it just doesn't seem right?

I agree it's not really right, could probably be implemented better, but I have yet to run into issues because I'm extending every View, and have not seen a noticeable performance hit.

gigafied avatar Mar 10 '15 23:03 gigafied

  1. tagless components no longer support $() (as it doesn't work/make sense) and this add-on now explodes.
  2. then just other times i have seen this sort of pattern. It often results in perf issues / hard to debug issues.

stefanpenner avatar Mar 11 '15 00:03 stefanpenner

#39 will close this :)

hhff avatar Apr 09 '15 19:04 hhff