gideros icon indicating copy to clipboard operation
gideros copied to clipboard

QScintilla's Korean IME error on character composition. (windows only)

Open bugcaptor opened this issue 9 years ago • 3 comments

Correct result(to-be): I tested this custom build of gideros. image

Wrong result(as-is): image Added redundant character in composition, and you cannot even move editing caret to other line!

Solution what I found: This problem comes from QScintilla's bug. No problem until 2.8.0 but has this error since 2.8.1. And that change is just two line of InputMethod.cpp. (red lines following image) image

If I erase that two lines, no problem at all.

I will report this bug and will try to fix the issue on qscintilla mailing list, but even if that is done gideros shoud update QScintilla latest version or just adapt that change only. What method will be the best?

  1. Fix in QScintilla latest release and update gideros's build upgrade latest version of QScintilla.
  2. Use custom build QScintilla custom built that just fix that bug.

I think 1) should be good, but 2) may be the answer if there is a reason that cannot upgrade gideros's build to QScintilla latest version.

Oh, and this bug only show in Windows OS system.

bugcaptor avatar Aug 31 '16 06:08 bugcaptor

We actually already do some patching of QScintilla before builds, so we can try to add that too but if it is fixed in some latest version, then sure, we can try to upgrade :)

ar2rsawseen avatar Aug 31 '16 08:08 ar2rsawseen

That's a good news!

Can you do that adding this fix to the patching? Or tell me how to add.

Also I'll notice if QScintilla latest version has this fix.

bugcaptor avatar Aug 31 '16 22:08 bugcaptor

For OSX we add the fix here: https://github.com/gideros/gideros/blob/master/scripts/installqscintilla.sh

So for windows it should probably go here:

https://github.com/gideros/gideros/blob/master/scripts/installqscintilla.bat

ar2rsawseen avatar Sep 01 '16 07:09 ar2rsawseen