gamemode-extension icon indicating copy to clipboard operation
gamemode-extension copied to clipboard
verified publisher icon gicmo

Enable "Do Not Disturb" when active (#15)

Open devmattrick opened this issue 4 years ago • 4 comments

This PR adds the "Do Not Disturb" toggle functionality that was mentioned in #15. This is also my first time working on writing GNOME extensions so please let me know if this could be improved in any way.

A small bug that I'm not entirely sure how to fix is there seems to be an issue where the "GameMode is inactive" notification gets sent before "Do Not Disturb" is fully disabled, which leads to the notification not popping up (it still is in the notification area, though). I'd be happy to fix this if anyone has any ideas on how to wait for the setting change to take effect.

Thank you for the awesome extension!

devmattrick avatar Jan 20 '22 04:01 devmattrick

So sorry, totally missed this! I will have a look asap!

gicmo avatar Apr 06 '22 20:04 gicmo

I think it might need adaptions now that #54 landed (sorry).

gicmo avatar Apr 06 '22 20:04 gicmo

No worries! I'll work on it when I get a chance.

I think I may also need to make it handle computer restarts because it's possible for do not disturb to get turned on and remain on after the computer restarts.

devmattrick avatar Apr 06 '22 22:04 devmattrick

@gicmo this should be ready for review! I believe the failing CI build may be unrelated to this PR but let me know if I inadvertently broke something :slightly_smiling_face:

Feel free to request changes as you see necessary!

devmattrick avatar May 04 '22 02:05 devmattrick