gibsondan

Hi @williamho123 - to help us prioritize this, can you say more about what problems the current behavior is causing? For example, are the extra pods while it's redeploying the...

I think it was in fact visibly increasing the workspace size but it remains unclear what the exact impact of that was - worth a quick chat maybe On Thu,...

A couple other details in case they're helpful: This is a starlette + uvicorn app running a graphql server. We've observed in in two different services with a similar setup...

I see a stop_timeout argument referenced here too that could in theory be set at run launch time? https://docker-py.readthedocs.io/en/stable/api.html But am unsure if the higher level api that we are...

I think it’s possible that container_kwargs.stop_timeout will work already for this with no code changes required? On Fri, Oct 18, 2024 at 9:08 AM gibsondan ***@***.***> wrote: > I see...

One option to make this less of a breaking change would be to enable this new behavior specifically in the case where a logger is defined at the Definitions level...

I can split out the threading the instance part. The main reason that was needed is that the "default system" colored console logger defaults to DEBUG, but if you specify...

I *think* this is probably fine, and the only reason we stopped checking it was the underlying assumption that when it was set it would always match the value on...

this test is an example of a situation from the PR summary that would not have errored before and would have just silently overridden the keys: https://github.com/dagster-io/dagster/blob/master/python_modules/dagster/dagster_tests/definitions_tests/declarative_automation_tests/automation_condition_tests/fundamentals/test_automation_condition_tester.py#L156-L160 If we want...

Definitely some dragons here as the various changes to the partitions definition and subset classes indicate. There were some places where we were implicitly assuming that if you subtracted two...