Richard Gibson

I find myself really wishing for this when interacting with the ECMAScript specification, which supports its own highlighting of variables in algorithms. For example, visit https://tc39.es/ecma262/multipage/notational-conventions.html#sec-returnifabrupt , click on the...

Proposed patch: ```patch diff --git i/packages/plugins/typescript/generic-sdk/src/visitor.ts w/packages/plugins/typescript/generic-sdk/src/visitor.ts index c05a1b817..709cf5d4f 100644 --- i/packages/plugins/typescript/generic-sdk/src/visitor.ts +++ w/packages/plugins/typescript/generic-sdk/src/visitor.ts @@ -6,6 +6,7 @@ import { DocumentMode, getConfigValue, indentMultiline, + transformComment, LoadedFragment, } from '@graphql-codegen/visitor-plugin-common'; import...

#1282

Note that full ISO 8601 includes a lot of representations that should probably not be available here, such as **P0.5M** (section 5.5.2.3: «_The lowest order component may have a decimal...

Related #195

> I know people tend to gloss over the frontmatter, but it is at least there. Thanks; acknowledged and updated. > Not as helpful when you're jumping to a specific...

> Hmm. I quite like having a clean separation between RoundingMode (what users specify) and UnsignedRoundingMode (what implementations need). I might agree with you if we didn't make comparisons against...

> https://unicode-org.github.io/icu4x/rustdoc/fixed_decimal/enum.UnsignedRoundingMode.html I don't have the context to evaluate how (or if) that might be different if the spec had already looked like I'm proposing in this PR, but the...

> There are two parts of this PR. The first 4 commits look fine to me. I would approve those as a separate PR. #983

> Is there still interest in abstracting away the duplicative constructor code? Yes, I'd still love to see that. > I'm a big fan of the idea, but given that...