Richard Gibson

This is pretty big... can you put together a jsPerf or other benchmark ([example](https://jsbin.com/cafumuloko/edit?html,js,output), and yes I'm aware of the irony) showing the value? ``` raw gz Sizes 65502 19586...

I am not comfortable with the size increase of this PR and don't know if it can come down enough to change that, although something like this could be attempted:...

@timmywil @dmethvin Do either of you foresee harm in changing the message (e.g., losing search results)? I _would_ like to be more clear and concise, and seem to remember an...

Yeah, that's it. Anyone who wants a stack trace is already free to pull it off the Error we throw, but our `Syntax error, unrecognized expression: …` messages leave much...

So you're suggesting different error messages for sizzle.js and sizzle.min.js? We could pull that off in this codebase, but it would impose complexity on downstream consumers like jQuery. It seems...

I don't know if anything has changed since the issue was opened, but it looks like this should be relatively easy to fix by adding something to [lib/InternalBytecode/01-Promise.js](https://github.com/facebook/hermes/blob/8dc886dabfe2fa90614294b23d08c845243300b8/lib/InternalBytecode/01-Promise.js) like ```js...

> Could you please point me where you see a missing field between the config.go and the toml.go? I cannot find any. Removing the bug label as it is more...

Possibly, although it seems better to keep argument/return shape checking independent of exportability.

I confirmed with engine262 that the test changes at https://github.com/tc39/test262/pull/3768 are the correct updates for this PR: https://github.com/engine262/engine262/compare/3248ccc6793a4de3ca6cab1d3a16a113ddc8d0c9...gibson042:ecma402-gh-709-initializedatetimeformat And since test changes are required, it's worth looking critically at the...

It's not a corner case in the RFC; [CNAME RDATA format](https://datatracker.ietf.org/doc/html/rfc1035#section-3.3.1) is just a \ and per [RFC 1035 section 5.1](https://datatracker.ietf.org/doc/html/rfc1035#section-5.1): > The labels in the domain name are expressed...