Richard Gibson

Results 268 comments of Richard Gibson
trafficstars

@linusg articulates a useful position at https://github.com/tc39/test262/pull/3845#issuecomment-1582515265 > The primary reason why I want to keep core harness files as simple as possible is to shrink the language subset required...

`JSON.parse(capDataStr)` is **deserialization** (it converts an input sequence of UTF-16 code units to an output tree-shaped data structure, for CapData in particular one that is expected to be an object...

I support including this, and there's even a use case in jQuery for asserting that early progress of an element animation approximates the pre-animation state (rather than e.g. introducing a...

@annevk By "treat this as a clarification issue", you mean continuing to preserve percent-encoding of characters outside the [RFC 3986 reserved set](https://www.rfc-editor.org/rfc/rfc3986#section-2.2) in https://url.spec.whatwg.org/#path-state ? That is permitted by the...

> Something seems fishy with the bench results. From what I gather, under node.js, the `encodes` and `JS encodes` should be using the same implementation, yet they have drastically different...

> Should I open a new PR for the benchmarking script improvements? #1986

> I am confused about the separation between this PR and #1986 , Both contain all three files. I would have expected one (that one) to define the benchmarking framework,...

#1986 is already incorporated, but it would be a good idea to land #1991 and then rebase this PR (which already shares its packages/base64/test/test-main.js) on top of the resulting master.

@kriskowal Since the two are at odds and the JS implementation isn't even used by XS, I'm comfortable with getting this PR clean and then closing it without merge as...

Hmm, I think that would need more discussion. In the text that you cite from [Strict Mode Code](https://tc39.es/ecma262/multipage/ecmascript-language-source-code.html#sec-strict-mode-code) and [ForIn/OfBodyEvaluation](https://tc39.es/ecma262/multipage/ecmascript-language-statements-and-declarations.html#sec-runtime-semantics-forin-div-ofbodyevaluation-lhs-stmt-iterator-lhskind-labelset) and [Changes to BlockDeclarationInstantiation](https://tc39.es/ecma262/multipage/additional-ecmascript-features-for-web-browsers.html#sec-web-compat-blockdeclarationinstantiation), the values that are being compared...