happa icon indicating copy to clipboard operation
happa copied to clipboard

Change getHumanReadableMemory to IEC unit

Open marians opened this issue 1 year ago • 2 comments

What does this PR do?

The idea of this PR is to enforce the use of IEC units wherever we print a data amount.

What is the effect of this change to users?

TODO, don't know yet where this has an effect

How does it look like?

TODO, don't know yet where this has an effect

Any background context you can provide?

  • https://intranet.giantswarm.io/docs/product/pdr/011-iec-units/
  • https://github.com/giantswarm/roadmap/issues/3529

Do the docs need to be updated?

No

Should this change be mentioned in the release notes?

Yes

marians avatar Aug 15 '24 08:08 marians

@gusevda Could you at some point please check this PR? I created it a while ago and failed to make tests work I think.

marians avatar Oct 07 '24 08:10 marians

@gusevda Could you at some point please check this PR? I created it a while ago and failed to make tests work I think.

I'll take a look

gusevda avatar Oct 07 '24 08:10 gusevda

@marians done, feel free to merge it.

gusevda avatar Oct 11 '24 11:10 gusevda