sirocco icon indicating copy to clipboard operation
sirocco copied to clipboard

The `bit32` module doesn't work with Lua 5.3

Open soapdog opened this issue 4 years ago • 4 comments

Bitwise operations in Lua 5.3 are using a different syntax. Maybe it would be better to support both 5.2 and 5.3. This also affects croissant.

soapdog avatar Dec 31 '19 02:12 soapdog

bit32 is used to ensure compatibility for all Lua versions. What exactly is "not working" with Lua 5.3?

giann avatar Dec 31 '19 06:12 giann

Luarocks marks bit32 as provided by the VM so when installing sirocco, bit32 is marked as already available. So those local band = bit32.band fail because bit32 is nil. It feels strange doesn't it?

soapdog avatar Dec 31 '19 14:12 soapdog

Which version of luarocks would that be?

giann avatar Dec 31 '19 16:12 giann

@giann I cloned it from the master branch yesterday. I've branched it to add support to Windows on Arm and Sirocco is one of the gems I was testing it with.

soapdog avatar Jan 01 '20 14:01 soapdog