Gian Merlino

Results 161 comments of Gian Merlino

People may find it difficult to update all their ingest specs, supervisors, etc, to ensure backwards compatibility. Is it possible to also add a runtime property that controls the default?...

Viewing this diff with whitespace hidden better illustrates what the changes are. Most of the lines changed are only indentation.

An IT is failing because there isn't a Docker container available yet for 3.9.1: ``` kafka Error manifest for bitnami/kafka:3.9.1 not found: manifest unknown: manifest unknown ``` I suppose we...

Or we could just update to 4.x.

Just to be clear, you are saying this only happens when using the ZK-less discovery in `druid-kubernetes-extensions`, right? I'm not familiar with how that extension works, although if you are...

This could be an extension of the `multiTopic` functionality, I suppose: the different topics may be able to come from different Kafka clusters. Is that how you were thinking of...

IMO, conceptually, there should be no problem having multiple supervisors per datasource. Nothing about the design of supervisors should limit that. Certain APIs do assume the supervisor ID and datasource...

Still seems useful. I believe it still requires the upgrade to SDK 2 described in #16903.

@bsyk @maytasm note I changed the last assert from #16562 from: ``` Assert.assertEquals(n, (Double) results.get(0).get(1), 0.001); ``` to: ``` Assert.assertEquals(n * segments.size(), (Double) results.get(0).get(1), 0.001); ``` Please let me know...