sqlalchemy-diff icon indicating copy to clipboard operation
sqlalchemy-diff copied to clipboard

Update comparer.py - added support for schema selection

Open rv-solomasov opened this issue 1 year ago • 3 comments

Adding the ability to select which schemas are being compared

rv-solomasov avatar Dec 18 '23 09:12 rv-solomasov

@gianchub I'd like to use this feature. code seems good to me

colonelpanic8 avatar Jan 28 '24 22:01 colonelpanic8

Hi @rv-solomasov and @colonelpanic8, so sorry I didn't get an email for this PR, but thanks to @colonelpanic8's mention I am now aware of it. The code seems good to me too, but can I ask @rv-solomasov to add tests to make sure the new feature works? I would add them myself but I have no time at the moment unfortunately. Thank you

gianchub avatar Jan 28 '24 23:01 gianchub

@colonelpanic8 @gianchub Hi! I'm trying to think of an appropriate tests to add here but nothing really comes to mind :) Apologies as this is my first contribution of a kind and I'm a bit lost with the general practices. I'm using this particular code with some additional improvements for aligning schemas between mysql and postgres dbs and have not experienced any issues as the added changes are only applied to built-in arguments of various Inspector methods

rv-solomasov avatar Feb 02 '24 07:02 rv-solomasov