psutil icon indicating copy to clipboard operation
psutil copied to clipboard

Published 20 hours ago • verified publisher icon giampaolo

Build wheels for arm64 on linux/mac

Open georgemarshall opened this issue 3 years ago • 5 comments

Summary

  • OS: Linux/macOS
  • Bug fix: no
  • Type: wheels
  • Fixes: -

Description

Change the build.yml to add aarch64/arm64 builds for M1 MacBooks. This covers both local and docker container use cases.

Closes #1782, closes #1945, closes #1954, closes #1966, closes #1972, closes #2090

georgemarshall avatar Feb 02 '22 23:02 georgemarshall

@georgemarshall could you add to your PR description Closes #1966, closes #1782, closes #2090, closes #1972, closes #1954, closes #1945 so the related issues get linked and will close upon merge?

ddelange avatar Apr 05 '22 08:04 ddelange

@ddelange ticket numbers have been added to link the issues.

georgemarshall avatar Apr 06 '22 19:04 georgemarshall

@ddelange ticket numbers have been added to link the issues.

Hmmm @georgemarshall, the PR description isn't updated with "closes ..." notes etc, so issues will remain open if this PR is merged. I'm confused.

I'd recommend naming this PR something more genal as well as this PR is more general than just Apple M1 support. For example "Build wheels for arm64 on linux/mac"

consideRatio avatar Apr 19 '22 23:04 consideRatio

@mayeut It looks like all your PRs are ready:

  • https://github.com/giampaolo/psutil/pull/2040
  • https://github.com/giampaolo/psutil/pull/2102
  • https://github.com/giampaolo/psutil/pull/2103

Any hope to see this merged soon and unlock this new wheel architecture?

Thank you so much!

warrenseine avatar May 20 '22 14:05 warrenseine

@warrenseine,

@mayeut It looks like all your PRs are ready:

  • https://github.com/giampaolo/psutil/pull/2040
  • https://github.com/giampaolo/psutil/pull/2102
  • https://github.com/giampaolo/psutil/pull/2103

Any hope to see this merged soon and unlock this new wheel architecture?

This question shall be directed to @giampaolo I provided some PRs but it's up to the maintainer of psutil to gauge interest in reviewing/merging those. I'll gladly answer any question/remarks he can have in those PRs.

mayeut avatar May 21 '22 09:05 mayeut

@giampaolo 🙏

I believe this is forcing users to install Command Line Tools since there is no wheel available.

rigogsilva avatar Oct 17 '22 20:10 rigogsilva

arm64 wheels for macOS were added as of https://github.com/giampaolo/psutil/pull/2040. Linux arm64 wheels will not be supported for now as per my previous comment: https://github.com/giampaolo/psutil/pull/2103#issuecomment-1252720051.

giampaolo avatar Oct 18 '22 19:10 giampaolo

Thanks @giampaolo! it is not forcing install of Command Line Tools for my M1 anymore. It uses the wheel. 😃

rigogsilva avatar Oct 18 '22 20:10 rigogsilva