jQRangeSlider icon indicating copy to clipboard operation
jQRangeSlider copied to clipboard

Better Bower Support / No need to compile library dependencies

Open nmccready opened this issue 10 years ago • 6 comments

including dest and prebuilt js files

Please see this post with regards to bower standards. http://stackoverflow.com/questions/17170500/how-make-bower-build-the-package

nmccready avatar May 31 '14 19:05 nmccready

Not sure that jquery-ui needs to be added to this dest directory.

ghusse avatar Jun 01 '14 11:06 ghusse

Is there a reason it is there in the first place? I never changed anything to the grunt file. So whatever is in the dist/dest was there in the build processes originally.

nmccready avatar Jun 01 '14 13:06 nmccready

They're just here for the demo page, which is included in the package.

I can remove them, I probably will.

The problem of this bower support is that it uses git for storing minified versions of source files. And I do not want to do this. It's like requiring to store binary executables in the same place as source code in C (or whatever). I don't like the idea.

Plus, it's a pain to maintain.

Now, if you come with a better idea, I'll agree to consider it and support bower.

ghusse avatar Jun 01 '14 20:06 ghusse

We can add whatever you want to ignore to the .gitignore and bower ignore list As for bower requiring minefield js filese.. That is false. There no idea of maintenance as it is just compiled / generated file. People with grunt , gulp, rails .. Etc will minify the file themselves.

Let me know what should be in the ignore list.

nmccready avatar Jun 01 '14 20:06 nmccready

I don't completely get your point, but as I'm not an user of bower, if you can propose a solution for supporting bower the good way, I'll be glad to add it. Le 1 juin 2014 22:42, "nmccready" [email protected] a écrit :

We can add whatever you want to ignore to the .gitignore and bower ignore list As for bower requiring minefield js filese.. That is false. There no idea of maintenance as it is just compiled / generated file. People with grunt , gulp, rails .. Etc will minify the file themselves.

Let me know what should be in the ignore list.

— Reply to this email directly or view it on GitHub https://github.com/ghusse/jQRangeSlider/pull/166#issuecomment-44788664.

ghusse avatar Jun 01 '14 21:06 ghusse

I just modified the .gitignore to not add non "end product" library files that are in the dest directory after a build. This way only what should be registered to be in bower is more to the point. I cleaned up the dest directory as well.

nmccready avatar Jun 01 '14 21:06 nmccready