Will Owens

Results 33 comments of Will Owens

~~Will push up a fix for the lint failures.~~ :checkered_flag:

@mdelapenya can you authorize another run of the CI test suite?

> The proposed idea is good; however, I lean towards prioritizing user flexibility. Introducing these changes as defaults could potentially break existing users who have already defined their own listeners....

I could see what it looks like to put all this behind functional options. It would differ from the other PR in that we're not going to allow you to...

I'm really looking forward to the gh-cli storing my non-expiring GH token inside a password store on linux. I hope we hear back soon on this question.

@williammartin On linux the GH Token secret is stored in plaintext on disk

@obreitwi I think I fixed the nix build which should help the CI pass here if you merge my PR into your branch that this PR is based on. 1....

> What needs to be done to get this merged? @splack I think we just need to fix the failing tests. Looking at them, it's complaints about missing modules.txt, trying...

I think the error is coming from this temporary module generation[1] that it utilized in the tests[2]. But not exactly sure as of yet what we need to change about...