qtreactor icon indicating copy to clipboard operation
qtreactor copied to clipboard

Testing with Twisted system

Open pythonmobile opened this issue 12 years ago • 6 comments

It would be nice if this codebase was automatically tested by the Twisted buildbot. Has this been talked about? With the release of 12.3.0, its high time perhaps?

pythonmobile avatar Dec 21 '12 21:12 pythonmobile

I've been in touch with the Twisted folks a couplea times.

The Qt Reactor was not included with the Twisted code because of licensing issues with PyQt. Now that it works with PySide (I'm told), it could be brought into Twisted itself.

IIRC, even the PyQt licensing might not be an issue any longer although that would need to be verified.

So, if someone wanted to do the work and get it into Twisted, I think everything becomes easier.

ghtdak avatar Dec 22 '12 01:12 ghtdak

The Twisted team are happy to include the code but they first need a way to test it. In my last job I set up a buildslave with python, pyside and a qt4reactor but I think this has stopped working since I left. It is probably relatively easy to get a pyside/linux build slave running, now that it's included in some distributions.

The other (bigger) problem is getting the entire twisted test suite to pass when using this reactor, there aren't many tests for the reactor and it is tested (at least partly) by having it run the entire test suite.

Michael

On 21 December 2012 21:00, pythonmobile [email protected] wrote:

It would be nice if this codebase was automatically tested by the Twisted buildbot. Has this been talked about? With the release of 12.3.0, its high time perhaps?

— Reply to this email directly or view it on GitHubhttps://github.com/ghtdak/qtreactor/issues/8.

michaelnt avatar Dec 24 '12 10:12 michaelnt

Way back when I originally wrote the Qt Reactor, Twisted Trial would run through, mostly without incident. The failures, IIRC, weren't concerning to the Twisted folks.

I haven't tried Trial lately... not with PySide or Qt5 (There's another thread on this topic).

ghtdak avatar Jun 11 '13 15:06 ghtdak

So any news? Would love to integrate PySide into my Twisted application - how would I be doing that these days?

marcusmoller avatar Jun 22 '13 12:06 marcusmoller

PySide is included. I'm not closing this thread because I really want somebody to hammer on the implementation with the twisted suite of testing tools. My environment has gotten a bit behind.

ghtdak avatar Sep 18 '14 20:09 ghtdak

So, the full blown run of trial

trial --reactor=[qt4 | pyqt4 | pyside] twisted

takes about a minute on a server class machine. The problem with the Twisted buildbot is that they'd need to maintain Qt.

However, I used to have a server supporting twisted... and I could probably do that again. I'll look into it. I'll leave this thread open

ghtdak avatar Sep 24 '14 22:09 ghtdak