Wes McNamee
Wes McNamee
Really for v2 we should start using the functional options API approach https://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis
@suhaibmujahid the functions _take_ a struct as it's only parameter, so it's _like_ passing in a struct, except you can differentiate between the zero-value of a field and whether or...
@suhaibmujahid I'll need a bit more on why you are saying it's not a good fit. Some example code would be great. In an effort though to continue this conversation,...
@andygrunwald actually there's not a lot of work here at all. Here's how we would do it: ```go type GetQueryOptions struct { ... } type CreateMetaOption func(queryOption *GetQueryOptions) func (s...
I think it makes sense to support a limited subset. It keeps us moving forward, and saves time when it comes to trying to figure out a "backwards compatible" way...
@andygrunwald do you have to `/unstale` it or will any comment work?
I think this whole method needs refactoring: https://github.com/andygrunwald/go-jira/blob/master/user.go#L182-L210 1. The query parameters & url should be constructed using the stdlib URL package. 2. I see now that the ability to...
@erutherford we are accepting PRs! :)
make the behavior configurable, both as a default in the config file, but also an overriding flag. ### Implementation If you pass `--edit` you'll be dropped into your user defined...
+1 this feature is super needed