lift-omniauth
lift-omniauth copied to clipboard
ghostm
Query on Scala 2.9 support
Hello! I'm looking to add a Travis build (as mentioned oin the Lift mailing list). As part of that I'm checking everything compiles OK.
I've noticed that an sbt +compile fails for Scala 2.9:
...
[info] Compiling 16 Scala sources to /Users/richard/tmp/lift-omniauth/target/scala-2.9.2/classes...
[error] /Users/richard/tmp/lift-omniauth/src/main/scala/omniauth/lib/FacebookProvider.scala:26: NonFatal is not a member of scala.util.control
[error] import scala.util.control.NonFatal
[error] ^
[error] /Users/richard/tmp/lift-omniauth/src/main/scala/omniauth/lib/FacebookProvider.scala:89: not found: value NonFatal
[error] case NonFatal(unknown) => {
[error] ^
[error] /Users/richard/tmp/lift-omniauth/src/main/scala/omniauth/lib/FacebookProvider.scala:90: not found: value unknown
[error] logger.debug("Something went wrong with the access_token : " + unknown)
[error] ^
[error] three errors found
[error] (compile:compile) Compilation failed
I'm checking in here to see if this is expected, and if so, if 2.9 is something we can drop as a supported version of this module?
I likewise hit a weird snag trying to compile the Scala 2.9.* compilers in sbt for lift-ng. IIRC, it looked as if it's because JDK 8 had some breaking changes. Nonetheless, I elected to drop the 2.9.x support.
How about a thread in the mailing list discussing dropping old version of both Scala and Lift in our active modules? I suspect we should only support 2.11/2.12 and 2.6/3.0/3.1 at this point in time.
I am cross compiling lift 2.6 modules using java 7 and 3.x using java 8 is that the culpit or is NonFatal simply post Scala 2.9?
Den 11 apr 2017 16:15 skrev "Joe Barnes" [email protected]:
I likewise hit a weird snag trying to compile the Scala 2.9.* compilers in sbt for lift-ng. IIRC, it looked as if it's because JDK 8 had some breaking changes. Nonetheless, I elected to drop the 2.9.x support.
How about a thread in the mailing list discussing dropping old version of both Scala and Lift in our active modules? I suspect we should only support 2.11/2.12 and 2.6/3.0/3.1 at this point in time.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ghostm/lift-omniauth/issues/51#issuecomment-293277015, or mute the thread https://github.com/notifications/unsubscribe-auth/AAu1p4lkBaBtCc6I8Pzxx7QUffXb0yo6ks5ru4sPgaJpZM4M6BPb .
My issue was much different that this one, so I have no idea. You know how sbt compiles the compiler for scala version "x.x.x"? That's where I was failing. So I just dropped 2.9.x and used JDK 8 across the board.
... as far as I know compiling Lift 2.6 modules using java 8 is not a good idea I have come across som werd runtime errors doing it so that should probably be a no no. From my mobile Best regards Peter Petersson
Den tis 11 apr 2017 16:22Joe Barnes [email protected] skrev:
My issue was much different that this one, so I have no idea. You know how sbt compiles the compiler for scala version "x.x.x"? That's where I was failing. So I just dropped 2.9.x and used JDK 8 across the board.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/ghostm/lift-omniauth/issues/51#issuecomment-293279280, or mute the thread https://github.com/notifications/unsubscribe-auth/AAu1px4dvaeAT1JHaEl2V0awVHorx4Dyks5ru4y8gaJpZM4M6BPb .
The cause of this particular error is the recent use of a Scala API that was introduced in 2.10 (NonFatal).
But yes, there's also the point raised of needing a version of Java before 8 for the a Scala 2.9 build (which gets us back to Lift 2.4 and 2.5). For Lift 3.x we're looking at 2.12 which needs Java 8. So that's an annoyance too.
Personally, I see it as a decision for the project maintainer, as they'll ultimately have to work around these kinds of things. I'll post on the mailing list to get more visibility.
Just a suggestion, have a final release of this module that supports 2.9 (excluding the latest fix is fine as far as I'm concerned), and then drop 2.9 from now on.
The reason for the stable release is so that people who use this module now, today, but are on the snapshot, can go to the final version and continue to use scala 2.9 on their apps. If they have been running it ok, it also means they have not used the facebook integration.
@ghostm any direction on what you'd like to see here, if anything, regarding 2.9?