user-agent-desktop icon indicating copy to clipboard operation
user-agent-desktop copied to clipboard

Customize Browser Version on Windows

Open remusao opened this issue 4 years ago • 3 comments

config/version_win.pl https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/config/version_win.pl#L116 https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/config/version_win.pl#L238 (used to be Mozilla Foundation) https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/config/version_win.pl#L239 (used to be Mozilla)

remusao avatar Sep 11 '20 13:09 remusao

related: https://github.com/ghostery/user-agent-desktop/pull/119 - maybe it should be the same patch

chrmod avatar Sep 14 '20 17:09 chrmod

Should we try to use preprocessor to inject values into those files? Then such change can be send upstream.

chrmod avatar Sep 14 '20 17:09 chrmod

This perl file has moved to python, and it looks like we can customise the windows version with build configs: https://searchfox.org/mozilla-central/source/config/create_rc.py#129

On the current build the version number mostly displays correctly, so I'll push this to the backlog.

sammacbeth avatar Sep 23 '20 11:09 sammacbeth