ghostery-extension icon indicating copy to clipboard operation
ghostery-extension copied to clipboard

Ghostery does not keep me logged-in

Open WFransL opened this issue 6 years ago • 57 comments

Ghostery does not keep me logged-in

I would expect that once logged in to Ghostery on a PC That Ghostery stays logged-in between sessions, Is is not what happens. Every now and then I have to log-in again.

  1. Start PC
  2. Open Browser
  3. Check if Ghostery is logged-in
  • Chrome 66.0.3359.117
  • WIN10
  • Ghostery 8.1.2

WFransL avatar Apr 21 '18 05:04 WFransL

Hi There, We've had dealt with this issue awhile ago, and we frankly thought it was fixed. We'd appreciate it if you could help us troubleshoot this issue by answering the following questions: When you are not using your machine, do you choose to: Log off: Clock: Sleep: Shutdown: How long do you normally leave your machine in the above state?

Chrome Settings:

Privacy and security ==> Content settings ==> Cookies Allow site to Save & read cookie data (On/Off): Keep local data only until you quit your browser (On/Off): Block third-party cookies (On/Off):

Privacy and security ==> Content settings ==> JavaScript

Allowed (On/Off):

System ==> Background Apps

Continue running background apps when Google Chrome is closed (On/Off):

Regards, Aziz

Aziz-Ghostery avatar Apr 25 '18 21:04 Aziz-Ghostery

See my responses

The issue of being logged out is not limited to Chrome. Also in MS-Edge Ghostery is logged-out.

When you are not using your machine, do you choose to:

One system is shutdown- ed when I do not used this system and the system is used daily Another system is always on (even does not ‘sleep’) and used daily

Chrome Settings: Allow site to Save & read cookie data (On/Off): On Keep local data only until you quit your browser (On/Off): Off Block third-party cookies (On/Off): Off

Privacy and security ==> Content settings ==> JavaScript: Allowed (On/Off): On

Continue running background apps when Google Chrome is closed (On/Off): Off

From: Aziz-Ghostery [mailto:[email protected]] Sent: Wednesday, April 25, 2018 11:32 PM To: ghostery/ghostery-extension [email protected] Cc: WFransL [email protected]; Author [email protected] Subject: Re: [ghostery/ghostery-extension] Ghostery does not keep me logged-in (#43)

Hi There, We've had dealt with this issue awhile ago, and we frankly thought it was fixed. We'd appreciate it if you could help us troubleshoot this issue by answering the following questions: When you are not using your machine, do you choose to: Log off: Clock: Sleep: Shutdown: How long do you normally leave your machine in the above state?

Chrome Settings:

Privacy and security ==> Content settings ==> Cookies Allow site to Save & read cookie data (On/Off): Keep local data only until you quit your browser (On/Off): Block third-party cookies (On/Off):

Privacy and security ==> Content settings ==> JavaScript

Allowed (On/Off):

System ==> Background Apps

Continue running background apps when Google Chrome is closed (On/Off):

Regards, Aziz

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ghostery/ghostery-extension/issues/43#issuecomment-384441129 , or mute the thread https://github.com/notifications/unsubscribe-auth/AkyqftVMtdNOFcdTPtl0CY1308pZGCYLks5tsOtmgaJpZM4TeU6p . https://github.com/notifications/beacon/Akyqfnq8vQihRcR3nUGtS-AP9507dqYSks5tsOtmgaJpZM4TeU6p.gif

WFransL avatar Apr 26 '18 04:04 WFransL

(Firstly : great extension)

But... me too, any thoughts much appreciated.

Ta

Mark


Windows 10 build 1709 64-bit Intel-i5 Chrome 66.0.3359.139

When you are not using your machine, do you choose to: Normally sleep or switch accounts with hibernation happening if left alone for 8 hours +

Chrome Settings:

Privacy and security ==> Content settings ==> Cookies Allow site to Save & read cookie data (On/Off): on Keep local data only until you quit your browser (On/Off): off [is that the problem??] Block third-party cookies (On/Off): off

Privacy and security ==> Content settings ==> JavaScript

Allowed (On/Off): on

System ==> Background Apps

Continue running background apps when Google Chrome is closed (On/Off): off

markofstrathclyde avatar May 08 '18 15:05 markofstrathclyde

same here i also always get logged out

konqui avatar May 31 '18 12:05 konqui

+1, Edge and Chrome keeps logging me out over time. For a while I stay logged in, then randomly get logged off. My other extensions I use keep me logged in all the time.

Windows 10 (every build I have used is affected).

computeronix avatar Jul 02 '18 19:07 computeronix

Same here. I have several machines, and I thought it saw a correlation there, when I log in to another machine it logs me off on the initial machine. Could it be that the user data is synced across devices?

oduis avatar Jul 03 '18 04:07 oduis

Definitely "me, too." I recall the "fix" some time back, but it only remained fixed for a few weeks. It's been logging me out constantly, ever since.

Doesn't seem to matter how I log-out of Windows (usually hibernate, or shut down), and my Chrome settings are as you specify above.

Happens all the time for me on Windows, and my Chromebooks.

FWIW, other extensions that maintain my sign-in (such as Trello, Evernote, etc.) do not have this problem. It definitely seems specific to the ghostery implementation.

WebGroupWest avatar Jul 03 '18 13:07 WebGroupWest

I see this also, is the "do not track" setting relevant?

mgrigni avatar Jul 05 '18 12:07 mgrigni

Hey guys, we hear you on the log-out issue. We have a new v2 API for our user authentication system that @trickpattyFH20 is currently integrating on the feature/api-v2-auth branch. It kills the old refresh token logic that caused all this headache. We're scheduling this for our 8.2.1 release hopefully next week.

christophertino avatar Jul 06 '18 20:07 christophertino

We released v8.2.3 earlier in the week which should resolve the logout issue. Please give it a test and let us know if you're still getting logged out.

One note: If you have your browser set to clear cookies on close you will be logged out of Ghostery. In Chrome, the setting "Keep local data only until you quit your browser" should be off. In Firefox, you should have Cookies and Site Data > Keep until they expire.

christophertino avatar Aug 10 '18 15:08 christophertino

The issue is fixed? On the contrary, login is completely broken for me (Arch Linux, Firefox). I cannot even login anymore. If I try it tells me my login attempt was successful but as soon as I close the Ghostery pop-up and re-open it I'm logged out again.

altae7 avatar Aug 12 '18 02:08 altae7

Thanks for the heads up @altae7. It looks like the Firefox implementation of chrome.cookies.onChanged is a little wonky. It was also causing problems on Edge. #158 should be the answer.

christophertino avatar Aug 14 '18 13:08 christophertino

Thanks. This means we have to wait for a new version to come out, right?

altae7 avatar Aug 14 '18 20:08 altae7

@altae7 yes a fix for this will be out with the next release ( PR #158 )

trickpattyFH20 avatar Aug 15 '18 13:08 trickpattyFH20

@christophertino +1 to @altae7's comment about Firefox - I am consistently getting signed out as well. Thanks for the upcoming fix.

mcicconi avatar Aug 21 '18 14:08 mcicconi

We found a few more edge-cases contributing to this issue that have now been patched. We're testing the release build now.

christophertino avatar Aug 21 '18 21:08 christophertino

@altae7 @mcicconi Ghostery v8.2.4 is now live. Please let us know if you can now remain signed in.

christophertino avatar Aug 23 '18 13:08 christophertino

Nope, closing EDGE logs me out each and every time.

I have unchecked to delete cookies upon closing in EDGE.

CCleaner leaves EDGE cookies untouched

Chrome works ‘as expected’ and I stay ‘logged-in’.

Frans Lichtenauer

P: +31 487540980

F: +31 878756623

M: +31 653171630

P Please consider the environment before printing this e-mail

From: Christopher Tino [email protected] Sent: Thursday, August 23, 2018 3:36 PM To: ghostery/ghostery-extension [email protected] Cc: WFransL [email protected]; Author [email protected] Subject: Re: [ghostery/ghostery-extension] Ghostery does not keep me logged-in (#43)

@altae7 https://github.com/altae7 @mcicconi https://github.com/mcicconi Ghostery v8.2.4 is now live. Please let us know if you can now remain signed in.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ghostery/ghostery-extension/issues/43#issuecomment-415416200 , or mute the thread https://github.com/notifications/unsubscribe-auth/Akyqfj2-bNL3s1chDwzkpEP5ApI9_aAXks5uTq-7gaJpZM4TeU6p . https://github.com/notifications/beacon/AkyqfnCyoumFt_o3VKtqt3SZvSuXkqCOks5uTq-7gaJpZM4TeU6p.gif

WFransL avatar Aug 23 '18 14:08 WFransL

Negative, still the same. I cannot login at all.

altae7 avatar Aug 23 '18 15:08 altae7

@altae7 We are working a logout issue for Edge Browser, However V 8.2.4 has the fix for Chrome and FF. Would you please restart your Chrome browser, make sure you are on V 8.2.4 and try sign in again. Please let us know the outcome, Thanks.

Aziz-Ghostery avatar Aug 24 '18 14:08 Aziz-Ghostery

I don't use chrome, I use Firefox. And login does not work despite the fact that Ghostery 8.2.4 is installed and I've restarted the computer several times in the meantime. It's simply broken.

altae7 avatar Aug 24 '18 15:08 altae7

@altae7 This might be due to a corrupted cookies.sqlite file in Firefox's profile folder. In order to fix this, just rename or remove cookie.sqlite while Firefox is not running. Open a terminal of choice and type the following: $ rm -f ~/.mozilla/firefox/.default/cookies.sqlite The profile id is a random 8 character string. Restart Firefox and see if it solved the problem. If the issue persists try creating a new FF profile reinstall Ghostery in that profile and see if the issue is solved.

Aziz-Ghostery avatar Aug 24 '18 19:08 Aziz-Ghostery

Just installed Windows 10 today. Installed Chrome including Ghostery (8.2.4). I have had to log on three times today already.

Lokumskaster avatar Aug 26 '18 19:08 Lokumskaster

I just noticed this as well. I can't stay logged in either.

@Aziz-Ghostery I tried deleting my cookies.sqlite but it did not fix it.

Arch Linux Firefox 62.0 Ghostery 8.2.4

Storm-Engineer avatar Sep 15 '18 01:09 Storm-Engineer

Hey guys, we're not having any luck reproducing the logout issue since the 8.2.4 release. Our auth is cookie-based, so if you are getting immediately logged out it means something is nuking the three cookies set on https://account.ghostery.com.

For testing purposes, please check your browser settings to see if you are blocking third-party cookies. If not, you can make an allow exception for ~~https://account.ghostery.com~~ https://consumerapi.ghostery.com (Preferences > Privacy > Cookies > Exceptions in Firefox). Also check to see if another installed extension may be deleting third-party cookies. Lastly, in Firefox if you have first party isolation enabled (custom setting in about:config) that will break our Auth.

Let me know if any of this helps.

christophertino avatar Sep 21 '18 08:09 christophertino

@christophertino I already had an allow exception for the whole ghostery.com domain.

The only cookie getting created is analytics.ghostery.com

Storm-Engineer avatar Sep 21 '18 16:09 Storm-Engineer

Ok, thanks for the reply. It's the first party isolation then. Since I'm not willing to disable it I'll live with not being able to login.

altae7 avatar Sep 22 '18 22:09 altae7

@christophertino I did some further testing. Apparently FF's handling of "3rd party" cookies is the issue.

I had 3rd party cookies set to "never allow", and using Allow exceptions for sites I use. This worked in the past. Now however, apparently it doesn't anymore.

Changing 3rd party cookies to "always" fixed the login issue and changing it back to "never" broke it again. This sounds like a Firefox bug to me because I'm pretty sure Allow exceptions should still work with 3rd party.

Storm-Engineer avatar Sep 23 '18 10:09 Storm-Engineer

@Storm-Engineer Can you try setting an Allow exception for https://consumerapi.ghostery.com ?

I was able to force the logout with third party cookies set to Never, but adding an exception for the above domain seems to clear it up. Let me know.

christophertino avatar Sep 25 '18 08:09 christophertino

@christophertino Yes, setting that exception soled it indeed.

But I already had an Allow for the main "ghostery.com" domain, and that should have did the trick already without explicitly setting the subdomain. Plus, other sites have malfunctioned lately as well (eg. YouTube kept forgetting the Dark theme and Autoplay settings) until I set it from Never to Visited.

So I still think Firefox started handling this differently, either intentionally or because of a bug.

Storm-Engineer avatar Sep 26 '18 15:09 Storm-Engineer