adblocker icon indicating copy to clipboard operation
adblocker copied to clipboard

Engines hold filter duplicates

Open chrmod opened this issue 1 year ago • 0 comments

While testing FiltersEngine.merge we've noticed that engines are able to keep duplicated filters.

Steps to reproduce:

const engineBlob = fs.readFileSync(pathToEngine);
const engine = FiltersEngine.deserialise(engineBlob); 
const emptyEngine = FiltersEngine.empty(engine.config);
const newEngine = FiltersEngine.merge([engine, emptyEngine]);
assert(engine.getFilters().networkFilters.length === newEngine.getFilters().networkFilters.length);
assert(engine.getFilters().cosmeticFilters.length === newEngine.getFilters().cosmeticFilters.length);

chrmod avatar Sep 11 '24 09:09 chrmod