react-search-box icon indicating copy to clipboard operation
react-search-box copied to clipboard

feat: Ability to no clear the search box when clicked outside

Open erezrokah opened this issue 2 years ago • 7 comments

Thank you for this lovely component 🚀

At the moment when you click outside the search box the text is cleared: https://github.com/ghoshnirmalya/react-search-box/blob/af881e89d6091c06aae11bd7ff0d129bf7026fb6/src/hooks/use-outside-click.ts#L12

Are you open to add a configuration to control that behavior? Some users might prefer to keep the text they typed

erezrokah avatar Mar 02 '23 19:03 erezrokah

@erezrokah Yes. That sounds like a reasonable request. Are you interested in adding that functionality?

ghoshnirmalya avatar Mar 08 '23 07:03 ghoshnirmalya

Sure I can submit PR. Thanks @ghoshnirmalya!

erezrokah avatar Mar 08 '23 11:03 erezrokah

What is the status of this issue? @ghoshnirmalya

chstavridis avatar Apr 07 '23 18:04 chstavridis

Sorry @chstavridis, that's on me I haven't been able to submit a PR yet. We'll try to do it this week

erezrokah avatar Apr 09 '23 06:04 erezrokah

hi guys, any way to fix this!

alymkarimg avatar Oct 11 '23 16:10 alymkarimg

@alymkarimg I noticed that you created a PR and then closed it. Would you like to build that functionality? I can help.

ghoshnirmalya avatar Oct 13 '23 20:10 ghoshnirmalya

Hi, Yh, I’d love to help! I’ve also got one more bug that can’t be fixed unless I change the search box to an uncontrolled component, would you be free for a video call anytime in the near future!

Kind regards Alym Karim

On Fri, 13 Oct 2023 at 21:26, Nirmalya Ghosh @.***> wrote:

@alymkarimg https://github.com/alymkarimg I noticed that you created a PR https://github.com/ghoshnirmalya/react-search-box/pull/180 and then closed it. Would you like to build that functionality? I can help.

— Reply to this email directly, view it on GitHub https://github.com/ghoshnirmalya/react-search-box/issues/170#issuecomment-1762157121, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF5GWCPZ3SUFDPPYKSZM5QTX7GPWVAVCNFSM6AAAAAAVNYK37OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRSGE2TOMJSGE . You are receiving this because you were mentioned.Message ID: @.***>

alymkarimg avatar Oct 13 '23 22:10 alymkarimg