Micromodal

Micromodal copied to clipboard

Modal window closes unexpectedly when 'mousedown' IN the modal and 'mouseup' on the background

7

Here's a video: https://drive.google.com/file/d/150mGwQNYmXyfykiVVdkw1VhCKvBhfQ96/view This is small but really annoying issue! p.s. the easiest solution is replace 'click' event by 'mousedown' (probably)

DimaGashko

If modal has much text - it will skip down to the last line

3

Yes, unfortunately a lovely work, that just does not cut it. If I have so much information that the scroll is enabled in the modal - the modal will open...

hejamartin

Bump terser from 5.6.1 to 5.14.2

1

Bumps [terser](https://github.com/terser/terser) from 5.6.1 to 5.14.2. Changelog Sourced from terser's changelog. v5.14.2 Security fix for RegExps that should not be evaluated (regexp DDOS) Source maps improvements (#1211) Performance improvements in...

dependabot[bot]

Can you please add an if statement to check if the Window object is defined. An example of one is below. Everytime I download this package I have to manually...

harryhaigh

onClose not called when provided to Micromodal.init

4

**Repo** ```js MicroModal.init({ onClose() { console.log('close') } }) MicroModal.show('my-modal') MicroModal.close('my-modal') ``` **Expectation:** "close" will be logged to the console **Actual:** Nothing is logged to the console When I provide the...

CoreyBurkhart

Breaking change in 0.4.9: clicking the container closes the modal

8

Hi, First, thanks a lot for this library! Just wanted to report that 32140ddf7b52178fd09d46cbb0ff9d3a610f0f82 (released in `0.4.9`) introduced a major breaking change: https://user-images.githubusercontent.com/35560568/145718230-26a60082-9022-4613-83ab-1104e744fb78.mov _Note: I'm running the docs locally in...

robinmetral

Add support for modal toggling and tracking all active modal instances

2

This pull requests adds support for closing all active modal instances (if no target modal is passed) and enables "toggling" of modals with `onShow`. Previously this behavior was buggy, and...

swg

target argument is getting the parent on Safari. OnShow method.

3

`MicroModal.init({ onShow: this.handleOpenModal.bind(this), });` Arguments passed to this function suppose to be modal and target, target is passing the body instead on safari browser.

isaacherrera47

Initialize multiple modals with different settings

1

I have multiple modals i need to use on the same site. Each modal would have different callback run after it opens. It is possible with micromodal?

piotrpog

Bump minimist from 1.2.5 to 1.2.6

1

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. Commits 7efb22a 1.2.6 ef88b93 security notice for additional prototype pollution issue c2b9819 isConstructorOrProto adapted from PR bc8ecee test from prototype pollution PR See full...

dependabot[bot]