swauth
swauth copied to clipboard
Token value < 60 breaks itokens
The itoken expiration time is set by the following code:
self.itoken_expires = time() + self.token_life - 60
That effectively means that setting token_life to a value less than60 secs
results in a token with an expiration date set in the past.
Is there a reason to subtract 60 secs from the token_life value? Perhaps it should be dropped.
Hmm. I checked the history on that line and -- after 4 years and the initial commit being the only commit for that line -- I honestly have no idea why the 60 is there. I guess nobody's ever set the token_life to under 60 seconds before either. =)
Hehe! We set it to 60secs so we could debug a driver's retry logic when the token has expired.
review for removing it here: https://review.openstack.org/246342 comments welcome