yaml icon indicating copy to clipboard operation
yaml copied to clipboard

Published 20 hours ago • verified publisher icon ghodss

Updating go.mod to take the latest release of go-yaml

Open njuettner opened this issue 4 years ago • 5 comments

Updating go-yaml to prevent abuse of high CPU/ memory consumption: https://github.com/go-yaml/yaml/releases/tag/v2.2.4

Issue where it was mentioned: https://github.com/kubernetes/kubernetes/issues/83253

njuettner avatar Oct 16 '19 15:10 njuettner

Awesome, I was about to submit the same patch! Thanks @njuettner.

petrkotas avatar Oct 17 '19 08:10 petrkotas

Hi @njuettner I have a proposal, would you please change the commit "Update go to version 1.13 " to add go 1.13 instead of replacing it? I believe this will make this simper to review.

Hi @ghodss would you mind please, taking a look at this PR? I believe it is relevant to the community using this great library. Thank you.

petrkotas avatar Oct 21 '19 08:10 petrkotas

You mean only adding go 1.13 in travis.yaml? If so this will break CI again.

It fails to build due because of the last line in go.mod which is automatically added when updating the dependencies (I'm using go 1.13 right now so it was added automatically).

I can try to use go 1.12 and also add it into Ttravis.

njuettner avatar Oct 23 '19 14:10 njuettner

I know, when I did PRs to other repos I manually deleted the go 1.13 line from all go.mods. This enabled the compilation on other go compilers.

I know it is a dumb, sorry for that.

petrkotas avatar Oct 23 '19 15:10 petrkotas

Hi @ghodss, sorry for bothering you. Would you mind taking a look at this PR?

petrkotas avatar Oct 24 '19 12:10 petrkotas