forestatrisk icon indicating copy to clipboard operation
forestatrisk copied to clipboard

Remove `numpy.distutils` dependency

Open thomasarsouze opened this issue 1 year ago • 3 comments

forestatrisk currently uses numpy.distutils which is now deprecated

Follow the migration advice to get rid of it, and make forestatrisk work with numpy>=1.23 and python>=3.12.

thomasarsouze avatar Jun 19 '24 11:06 thomasarsouze

Done, see e5e4872.

ghislainv avatar Jun 19 '24 18:06 ghislainv

This was done a bit too fast actually !

We are facing this problem where numpy is now needed for the setup, but is not installed in a clean environment.

Setuptoolofficial solution is to add a pyproject.toml file. This is what is proposed in the PR, although not ideal right now as there is a mix of pyproject.toml and setup.py (and setup.cfg). All this should be merged into a single pyproject.toml later on.

thomasarsouze avatar Jun 25 '24 08:06 thomasarsouze

OK, thanks. In previous versions of forestatrisk we also needed to install numpy previously to forestatrisk. But it is cleaner that way. I let the issue open until we merge pyproject.toml and setup.py.

ghislainv avatar Jun 25 '24 20:06 ghislainv