angular-markdown-editor icon indicating copy to clipboard operation
angular-markdown-editor copied to clipboard

Update to Angular 14 required due to deprecated dependencies (core-js)

Open Adam-Pond opened this issue 2 years ago • 2 comments

What are the chances someone could publish an updated version?

warning angular-markdown-editor > [email protected]: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

Adam-Pond avatar Jul 30 '22 01:07 Adam-Pond

If you want to help and provide Pull Requests to update necessary stuff, I'd be happy to cut a release afterward. I just don't have the bandwidth to work on this at the moment.

ghiscoding avatar Jul 30 '22 01:07 ghiscoding

looking at the package.json and I guess that core-js and vinyl-paths can simply be moved from dependencies to devDependencies or simply be removed and that would fix the security issues. It would be nice to get a contribution if you're up to it

https://github.com/ghiscoding/angular-markdown-editor/blob/5435f61284d0e16cdc7831f1c1a820ea0e12465b/package.json#L44-L52

ghiscoding avatar Jul 30 '22 03:07 ghiscoding

the change is done, see new v3.0.0 release

ghiscoding avatar Sep 12 '22 13:09 ghiscoding