angular-meditor icon indicating copy to clipboard operation
angular-meditor copied to clipboard

Features/style changes

Open Benjamin23 opened this issue 7 years ago • 2 comments

Hi,

Here is a list of changes that I've made:

  1. Replaced grunt with gulp.
  2. Added options to pass font sizes and font families to the directive
  3. Added alignment options to the toolbar
  4. Added color picker option
  5. Some minor refactoring in the editor directive
  6. Fixed issue with font size and familiy on android devices

Benjamin23 avatar Oct 06 '17 09:10 Benjamin23

Hi,

A couple of quick notes:

  • I'm ok with replacing Grunt with Gulp, it's just that the gulpfile is missing a couple of things right now:

    • The grunt-buildcontrol task deploys the simple demo site to github pages. It pushes the public folder to the gh-pages branch.
    • The jshint task.
  • I want to keep the dist folder in the repo, so people can just install the package and not have to use a build tool to use it.

ghinda avatar Oct 10 '17 16:10 ghinda

I replaced gulp with grunt and reversed some of the configs. I kept all the new features you added.

It's on a different branch: https://github.com/ghinda/angular-meditor/tree/features/style-changes

Found a couple of issues:

  • On Firefox, the size always reverts to the original size after changing it
  • Dropdowns stay open when clicking outside or selecting an item. They close only when clicking the main toggle button. Could you change the custom dropdowns with native select elements?
  • Could you detect the color of the selected text, and set it as the color input color when the toolbar appears?

Any chance you could make these changes? Make sure to rebase from the new branch.

ghinda avatar Nov 09 '17 09:11 ghinda