jwamp

jwamp copied to clipboard

The WaitResponse.java class has a race condition

1

The WaitResponse.java class has a race condition: public synchronized T call() throws Exception { wait(waitfor); return result; } The result may already have arrived before the call() method is invokded....

chuckmarcotte

DefaultRPCSender - Possible race condition between sending and registering the listener

6

In the class DefaultRPCSender, in method call(): public String call(String procId, ResultListener listener, long timeout, Object... args) the line for: ``` conn.sendMessage(msg); ``` Is invoked before the listener is registered...

chuckmarcotte

I'm seeing the following scenario as a strong possibility: 1. Single dispatcher gets created in WampServerEndpointConfig 2. Client connects, server constructs a new WampServerEndpoint (with the dispatcher) 3. this calls...

trumpetinc

ExtendedWampEndpoint constructor

1

It looks like adding support for JSR356 resulted in a loss of control of the end point constructor that gets called. This means that the ExtendedWampEndpoint(WampDispatcher dispatcher) contstructor can't be...

trumpetinc

There seems to be a lot of plumbing (including reflection) to support registered message handlers, multiple message handlers, etc... in DefaultWampDispatcher. I'm wondering if this flexibility is necessary? It seems...

trumpetinc

Design for annotation based Actions

2

I think it would be a good idea to start discussion what annotation based action specification might look like. This may be controversial, but I thought I'd toss it out...

trumpetinc

Remove WampBuilder.setActionMapping()

2

Remove WampBuilder.setActionMapping() and DefaultRPCManager.setActionMapping() methods. Instead, have an addAll() method that copies the values from an existing mapping. The current implementation allows a user to accidentally destroy previous configuration.

trumpetinc

Design intent of Action, CallAction, CompleteCallAction

3

I had some thoughts on this part of the design: I think that the ideal end-user case would be to use an annotation based system, backed by a class implementation...

trumpetinc

CallAction interface design comments

2

The CallAction interface defines a couple of enum values for unusual return types. I'm wondering what the purpose of these is? I may be misunderstanding the design intent, but if...

trumpetinc

TimeoutHashMap alternative

6

I've merged all issue related to TimeoutHashMap here. The idea is to use an alternative rather than "fixing" the actual implementation. merged from #23 #24 #25

ghetolay