ght-acme.sh icon indicating copy to clipboard operation
ght-acme.sh copied to clipboard

outdated agreement file

Open kowloon12 opened this issue 6 years ago • 2 comments

286c286
<     NEW_REG='{"resource":"new-reg","contact":["mailto:'"$ACCOUNT_EMAIL"'"],"agreement":"https://letsencrypt.org/documents/LE-SA-v1.0.1-July-27-2015.pdf"}'
---
>     NEW_REG='{"resource":"new-reg","contact":["mailto:'"$ACCOUNT_EMAIL"'"],"agreement":"https://letsencrypt.org/documents/LE-SA-v1.1.1-August-1-2016.pdf"}'

kowloon12 avatar Jul 06 '17 10:07 kowloon12

I believe this is a duplicate of: https://github.com/gheift/letsencrypt.sh/issues/32

And three! unmerged pull request to patch over it exist: https://github.com/gheift/letsencrypt.sh/pull/27, https://github.com/gheift/letsencrypt.sh/pull/26, https://github.com/gheift/letsencrypt.sh/pull/30

As I commented on #30 having a hardcoded agreement URL is the wrong way to write an ACME account registration flow. Unfortunately it seems this repo is unmaintained :'(

cpu avatar Jul 06 '17 12:07 cpu

Hi @cpu , I am not really writing this to you rather to everybody else reading that issue. I agree, this repo seemingly isn't maintained any more. On the other hand I am trying to fully maintain my fork, https://github.com/bruncsak/letsencrypt.sh where I fixed the "outdated agreement file" issue among lot of other issues. That issue is not simply solved by updating the hard-coded version, rather the URL of the up-to-date version of the agreement dynamically looked up from the directory.

So I suggest everybody to start working directly with my version. I enabled the "issues" section in my fork of repository to allow feedback for it. Do not hesitate to open issues there if you have problem with my version, otherwise do not forget to star my fork.

bruncsak avatar Jun 12 '18 12:06 bruncsak