"Getting GitHub repository info" fails with "Err: Not Found"

[horgh]

This was with version 0.46 as well. The same release as in #55.

In the build step I see this:

[@MAXMIND/GitHub::Meta] Getting GitHub repository info
[@MAXMIND/GitHub::Meta] Err:  Not Found
[@MAXMIND/GitHub::Meta] Using offline repository information

However I was online. I continued with the release as I didn't notice this. Likely it would be better to fail completely rather than continue here.

The META.json/META.yml files ended up with invalid info for the repository, and missing the GitHub issues link.

Thank you!

[karenetheridge]

This happens when auth fails or is misconfigured. It would probably be reasonable to have a configuration setting here to indicate whether to fail the build outright, or to warn and keep going, as I can see usecases for both.

[horgh]

Oh okay. At that point it hadn't prompted for my password. Should it have?

[karenetheridge]

I don't think any of the auth paths are interactive, but a lot has moved around lately in some PRs.

[horgh]

Well I do definitely get prompted for my GitHub password usually, but not at this point.

Regarding what happened: I think this was my fault. You can see here that the pattern to find the repository name includes .git in the URL. My remote is this:

# git remote show -n origin|grep Fetch
  Fetch URL: [email protected]:maxmind/GeoIP2-perl

So the pattern failed and we ended up trying to use the repo name horgh/GeoIP2. That doesn't exist and so we get a 404.

That remote URL I have appears non standard, though it does work.

Once I change the remote URL to have a .git suffix, this works again.

Regarding #55: I wonder if this impacted that too & a release would work now... I'm not sure how to test it without doing a real release though!

Sorry for the noise. We could close this I suppose. Although defaulting to failing the build might be better, so we could keep it open if having an option for that would be worthwhile.

[karenetheridge]

aha! sounds like the regexp should be softened a bit then.

I'm not sure how to test it without doing a real release though!

You can do a "release" by swapping out [UploadToCPAN] and adding [FakeRelease] in its stead (I'd also comment out things like [Git::Tag] and [Git::Push] so you don't have to fix your repository afterward).

[horgh]

I tried a real release with another distribution. The same infinite loop as in #55 happened. The meta part worked fine though!