Greg Hazel

resuming from a failed rebase

2

Resuming from a failed rebase also needs to re-apply the stash. Should there be a git smart command for resume? Or at least an additional note in the error message....

visit_children SIGABRT

14

Reproducible with code which is kind of long, but nests visit_children calls. ``` (lldb) bt * thread #1: tid = 0x2c0a0f, 0x00007fff90e1437a libsystem_kernel.dylib`__pthread_kill + 10, queue = 'com.apple.main-thread', stop reason...

temp_extend breaks the Class

1

ruby 1.8.7 p249 This was the Rails bug I mentioned on IRC, but it turns out it's fully reproducible without Rails at all. The instance and class methods mimic a...

NSProgress

1

A feature request; for determinate progress indicators, a way to hand them a NSProgress to display.

percentile indexing issue

1

``` ruby [412, 10].percentile(90) NoMethodError: undefined method `-' for nil:NilClass ```

Add SDWebImage dependency

1

Closes #23

In a window sized 1026x797, the `DKPhotoGalleryScrollView` has dimensions 1026x797 however the `DKPhotoImagePreviewVC` is sized 960x540. The presentation animation is correct, but when completed the `DKPhotoImagePreviewVC` is the wrong size.

When a UIImage has an orientation other than `UIImageOrientationUp`, `DKPhotoGallery` displays the image incorrectly. My simple `UIImageView` gallery shows the image correctly, but then opening it fullscreen it is displayed...

This commit https://github.com/zhangao0086/DKPhotoGallery/commit/a420b687cd7ae3b1e6b2b696db0f98bc00697aab removed the `SDWebImage` dependency from `Carthage` (by virtue of removing `SDWebImageFLPlugin`), but `SDWebImage` is still needed: https://github.com/zhangao0086/DKPhotoGallery/blob/develop/DKPhotoGallery/Preview/ImagePreview/DKPhotoImagePreviewVC.swift#L129 (etc) Building depending on `DKPhotoGallry` with `Carthage` yields: ``` /Users/me/projects/app/Carthage/Checkouts/DKPhotoGallery/DKPhotoGallery/Preview/ImagePreview/DKPhotoImagePreviewVC.swift:129:25:...

The example doesn't handle swiping or proper image sizing in Mac Catalyst.