Gavin Halliday

Appologies.... Looking back I see that my comment was truncated by github, so it wasn't clear. What I meant to say was "Did you consider storing an Owned\ in this...

> Yeah, I figured as much, but w/out the queryTrace/Span, it didn't make sense. I don't know if you recall, but I originally had those 2 methods in the ispan...

On my radar - I am planning to take a look next week.

> Re. naming, I'd go renaming the 3 stats to: > > StSizePeakInterSubgraphDisk StSizePeakInternalTempDisk StSizePeakEphemeralDisk > > @ghalliday ? And what do StSizeSpillFile and StSizeGraphSpill become? (I'm not quite sure...

> > StSizeInternalTemp > > @ghalliday If I have understood correctly, shouldn't StSizeInternalTemp be zero at the end of each activity? Yes. I'm not sure it is useful - but...

@jackdelv please can you rebase onto the lastest master - it will remove some of these changes.

@mckellyln this is curious - the number of reported contentions is much lower than the real value. I think the reason is that the overhead of the lock calls/returns is...

@richardkchapman , please can you sanity-check this change

When we finally drop centos 7 support this should be looked at again.

Not tested.... will need close inspection.