Gavin Halliday

Here is my suggested replacement code (untested): ``` namespace { class TlsRandomNumberGenerator { public: TlsRandomNumberGenerator() noexcept { Seed(); } FastRandomNumberGenerator & engine() noexcept { return engine_; } private: FastRandomNumberGenerator engine_;...

Pushed for discussion (although I think it could be merged). I don't particularly like the way that an extra parameter is needed to be able to record the ids, but...

Conclusions from discussion: - It would be better to only do this if the query was above a certain threshold/SLA - Even better would be to generate a stats workunit...

@richardkchapman I have added some timing tests. It has an impact of ~1ns for every activity that isn't in the top 5 and about 10ns for each activity that is....

@mckellyln would this be better to only report if the slowest activity was above a certain threshold (e.g., 10ms), or is it always useful?

Added an extra guard condition, ignoring all activities < 10ms. (Compare ignoring case.)

@mckellyln this option will be available in 9.4.x. It would be worth testing it on the development systems once this build is deployed to see what effect it has on...

@dcamper please squash and I will merge.

@shamser do you want to merge as-is, or will you add the new function in this PR?

> > ime_since_epoch()); > > @ghalliday if there are other places that would benefit from more nano-second accuracy timestamps, I'd prefer to make the the suggested change in a separate...