Eugene Obrezkov

Results 135 comments of Eugene Obrezkov

@gmoniava you made me to think a minute here 😄 Yeah, I remember now that we don't use distribution here at all, but instead checking if the element is in...

@dianrahmaji try to solve it and feel free to leave a comment with the updated solution for other people to see.

@gmoniava read further on, I wrote: > the actual implementation for this turned out to be really quirky. I don’t like it, take a look > So I’ve started thinking,...

@gmoniava > You could iterate without `I extends any ?` check also, isn't it? What cases does that check protect against? You can't. `T[number] extends any ? ... : ...`...

@gmoniava ah, I don't remember why. If they both pass, then the other one is better, yes.

@AurelienWebnation feel free to add a PR with the proposed update. As I see it, it can be placed after the original solution with the note that there is an...

@Brysonmk1984 without it, you will get an error: > The type 'readonly ["tesla", "model 3", "model X", "model Y"]' is 'readonly' and cannot be assigned to the mutable type 'PropertyKey[]'....

@AurelienWebnation it is a safer way to say “any”, roughly speaking. I use it whenever I can instead of `any`. You can read more about it in the TypeScript documentation.

@Beastlybear2017 you can try to write a test, where to check if your solutions works. Here, for instance, test case that checks if the `notifyChange` works: https://github.com/ghaiklor/icecast-parser/blob/e6ba7a3cb7161eb0c9ce08039533fa5f8afa1dda/test/Parser.spec.ts#L57-L65 You can add...

Great work! However, let's keep it backward compatible with older API. Let's leave the possibility to specify the boolean as before.