Gregory Haerr

Results 674 comments of Gregory Haerr

> kilo editor does not recognise umlaut This also could possibly be an internal sign-extension problem, using `char` instead of `unsigned char` when reading single characters out of a buffer....

Thanks for the binary test file, I'll keep that for debugging when needed. > in macOS cat shows me ? starting with 0x80 I think the reason for that is...

And here is `kilo` editing your binary file on QEMU: ![Screen Shot 2023-10-08 at 2 31 38 PM](https://github.com/ghaerr/elks/assets/11985637/b53249ea-b498-4dac-a108-151c3066b862) It would appear its not (just) a sign extension problem, but something...

Use LF only. Here's MINIX `edit` on your file: ![Screen Shot 2023-10-08 at 2 36 55 PM](https://github.com/ghaerr/elks/assets/11985637/189b579d-e510-45be-8f39-129c5f9e8348)

Here you go. Easily converted using `:set ff=unix` in `vi`, then `:wq`. [20-ff-bin.txt](https://github.com/ghaerr/elks/files/12841836/20-ff-bin.txt) Both edit and kilo now show the right edge correctly, but kilo's problems remain. Kilo: ![kilo](https://github.com/ghaerr/elks/assets/11985637/d2f4a50e-d213-48b5-9e16-492800cffbe2) Edit:...

I have identified the display problem in kilo.c: ``` /* Handle non printable chars. */ if (!isprint(*p)) { row->hl[i] = HL_NONPRINT; p++; i++; prev_sep = 0; continue; } ``` The...

> Thank you for fixing isprint, now everything works as expected Great! You're still going to submit a PR at some time for the keyboard changes, right? > I try...

Hello @Vutshi, Would you like to post the source to your modified German keyboard file? I'd be happy to add it so that ELKS is up-to-date with your enhancement. Same...

Hello @stevexyz, Thanks for your interest in ELKS. A few years back, the project switched from using bcc to ia16-elf-gcc to build the kernel and all the applications. One of...

I thought more deeply about exactly what is entailed when someone says "I'd like a C compiler" to run native on ELKS. As @tyama501 and @stevexyz mentioned, it would be...