ggtrackerstack icon indicating copy to clipboard operation
ggtrackerstack copied to clipboard

Promote ggtracker/sc2reader to be the official version

Open dsjoerg opened this issue 8 years ago • 3 comments

From @dsjoerg on July 16, 2014 18:47

Currently we use an old and behind version of sc2reader: https://github.com/ggtracker/sc2reader/tree/upstream

Which is less efficient, and also not as easily compatible with the newer sc2reader.

Copied from original issue: dsjoerg/ggpyjobs#1

dsjoerg avatar Apr 18 '16 17:04 dsjoerg

From @dmpaul26 on March 11, 2016 2:58

Since the version currently used is a bunch of commits ahead and behind the newer sc2reader, my thought was comparing the two branches and going through each commit from the newer sc2reader and make sure there are no conflicts, then checking for logic/runtime compatibility?

This is also old, I'm sure the incompatibility has gotten even more extreme?

dsjoerg avatar Apr 18 '16 17:04 dsjoerg

This would be difficult, more difficult than all the other things we've talked about doing.

dsjoerg avatar Apr 18 '16 17:04 dsjoerg

Since GraylinKim/sc2reader is no longer under active development, the more recent thought is to promote https://github.com/ggtracker/sc2reader/tree/upstream to being the official sc2reader

dsjoerg avatar Nov 16 '16 14:11 dsjoerg