Grant Griffiths
Grant Griffiths
/ok-to-test
My concern with this is continued support of helm charts by the maintainers, I am not sure if that's something the team would have the bandwidth to do for every...
> We too would really like an easy way to actually install this.. What other way do you recommend, instead of using a Helm Chart? The deployment files under [deploy/kubernetes](https://github.com/kubernetes-csi/external-snapshotter/tree/master/deploy/kubernetes)...
> > My concern with this is continued support of helm charts by the maintainers, > > Maybe the solution is to generate the plain manifests from the helm chart...
Yes, there are many spots where we still use "update" instead of "patch": - [ ] Update: ``` pkg/common-controller/snapshot_controller.go:1383: newSnapshot, err := ctrl.clientset.SnapshotV1().VolumeSnapshots(snapshotClone.Namespace).Update(context.TODO(), snapshotClone, metav1.UpdateOptions{}) pkg/common-controller/snapshot_controller.go:1454: updatedSnapshot, err = ctrl.clientset.SnapshotV1().VolumeSnapshots(snapshotClone.Namespace).Update(context.TODO(),...
/assign @camartinez04
/unassign @camartinez04
Unfortunately, there isn't much that can be done about this. CRD short names aren't reserved, so any community CRD short name can conflict with another. As a workaround, you can...
I'm assuming we wouldn't want to rename `vs` to `vsn` as that isn't backwards compatible, but will defer to @xing-yang .