the_silver_searcher icon indicating copy to clipboard operation
the_silver_searcher copied to clipboard

Use gitignore from file's repository

Open forgottenswitch opened this issue 8 years ago • 8 comments

Fixes https://github.com/ggreer/the_silver_searcher/issues/883

forgottenswitch avatar Nov 23 '16 00:11 forgottenswitch

Neat, thanks for working on this! I think the usual term is "parent folder". I hope this will be merged!

cpitclaudel avatar Nov 23 '16 05:11 cpitclaudel

It segfaults in the tests so... probably not going to get merged.

ggreer avatar Nov 26 '16 02:11 ggreer

Rebased and updated for 1.0.1

forgottenswitch avatar Nov 28 '16 00:11 forgottenswitch

+1 to this!

@ggreer can we get this merged please?

Vijar avatar Dec 08 '16 19:12 Vijar

@ggreer I landed here looking for a solution to this issue.

I checked out and compiled the latest version from @forgottenswitch, and it seems to work as advertised. It makes my life easier when wandering around the codebase I'm currently spending the most time in at $DAYJOB.

Per the CI results above, the rebased version shows no sign of the segfault you mention from the original submission. make test says:

# Ran 39 tests, 1 skipped, 0 failed.
clang-format is not available. Skipped clang-format test.

I can offer a basic test for this functionality, which this PR doesn't seem to have yet.

Would you reconsider merging this?

NateEag avatar Jan 23 '17 15:01 NateEag

The previous version (backed up at https://github.com/ggreer/the_silver_searcher/compare/master...forgottenswitch:gitignore_win32) had two issues:

  • Did not handle sub-repositories
  • Tried to handle Win32 paths
  • Also had a base_path -> path typo in search_dir :)

Now this partially implements #284 the other way (read ignores into another list instead of restricting the current one).

forgottenswitch avatar Mar 31 '17 18:03 forgottenswitch

Factored tests and function names for readability. Squashed commits to avoid the flood. Added more tests. Stopped attempting a malloc-less dirname, – just using copies now.

forgottenswitch avatar Jun 20 '17 22:06 forgottenswitch

There are about 5 issues for the problem this PR is trying to solve, it'd be great if we could revive it.

rr- avatar Mar 05 '18 18:03 rr-