GutterColor icon indicating copy to clipboard operation
GutterColor copied to clipboard

Colors are off if using hsl

Open mven opened this issue 10 years ago • 7 comments

screen shot 2015-01-21 at 3 54 03 pm

The first line shows as red, while the others show up correctly.

(They should all look the same teal/blue)

mven avatar Jan 21 '15 21:01 mven

Looks like the values are being interpreted wrong?

jbrooksuk avatar Jan 21 '15 21:01 jbrooksuk

Yep – that's a better way to put it :)

mven avatar Jan 22 '15 15:01 mven

It's the ImageMagick parsing issue seen in #61 and #69.

(Thanks for the reminder on that :wink:)

tdhsmith avatar Jan 22 '15 16:01 tdhsmith

Ah yes, I forgot about that.

jbrooksuk avatar Jan 22 '15 16:01 jbrooksuk

I think the best way is to parse the color from python and render it latter (may be by using pure python too).

leiserfg avatar Apr 08 '15 23:04 leiserfg

Will HSL only ever be written either (deg, %, %) or (%, %, %)? Or do we need to code for other formats as well?

andytruett avatar Apr 23 '15 20:04 andytruett

@andytruett I would expect to find people using decimals [0.0-1.0] in most of the same contexts as percentages, especially with the increase in alpha channel usage.

Also to recap, IM only accepts (deg, 8bit, 8bit) or (%, %, %), so in order to support the standard (deg, %, %) we'll need to convert at least one number on our end. Once we've done that, we can basically add arbitrary formats 'for free'.

tdhsmith avatar Apr 23 '15 21:04 tdhsmith