llama.cpp icon indicating copy to clipboard operation
llama.cpp copied to clipboard

cmake: make sanitizers linking

Open Green-Sky opened this issue 1 year ago • 4 comments

clearly no one tested this.

Green-Sky avatar Mar 24 '23 16:03 Green-Sky

@ggerganov :smirk: enabling asan and detecting memory leaks (see ci)

Green-Sky avatar Mar 25 '23 00:03 Green-Sky

Maybe add separate sanitize CI like in whisper.cpp:

https://github.com/ggerganov/whisper.cpp/blob/8e361d90d7948de3ecae73e10878040044836800/.github/workflows/build.yml#L92-L116

ggerganov avatar Mar 25 '23 04:03 ggerganov

@Green-Sky should i port these changes to the format in #497

anzz1 avatar Mar 25 '23 17:03 anzz1

@anzz1 sure, go ahead. will have some time later to check.

Green-Sky avatar Mar 25 '23 17:03 Green-Sky

@anzz1 sure, go ahead. will have some time later to check.

Done.

anzz1 avatar Mar 25 '23 19:03 anzz1

merge into https://github.com/ggerganov/llama.cpp/pull/497

Green-Sky avatar Mar 25 '23 20:03 Green-Sky