llama.cpp icon indicating copy to clipboard operation
llama.cpp copied to clipboard

Check for reverse prompt by characters instead of tokens (#292)

Open tjohnman opened this issue 1 year ago • 2 comments

This fixes bug #292 as suggested here.

tjohnman avatar Mar 20 '23 15:03 tjohnman

Not sure we need the string stream here.

Green-Sky avatar Mar 20 '23 15:03 Green-Sky

Not sure we need the string stream here.

@Green-Sky Should we use std::string::append() or the sum operator instead? What do you suggest as the most efficient alternative?

EDIT: I used addition. Please let me know if there are any other issues.

tjohnman avatar Mar 20 '23 15:03 tjohnman