llama.cpp icon indicating copy to clipboard operation
llama.cpp copied to clipboard

Docker - Fix publish docker image in GitHub Registry

Open bernatvadell opened this issue 1 year ago • 1 comments

In the PR that was resolved (#132), the action defined to publish the packages used the user and token of the author of the commit in master.

In this case, I have been yours, but I do not have permissions for such an action.

That is why I have modified the file, so that the owner's token is included as a secret with the name GHCR_PAT.

It is important to select the read:packages & write:packages permissions.

NOTE: Checks will fail until the secret is included.

bernatvadell avatar Mar 17 '23 09:03 bernatvadell

Would github.repository_owner / secrets.GITHUB_TOKEN work? (with the appropriate permissions, namely packages: write)

j-f1 avatar Mar 17 '23 12:03 j-f1

Let me know if I need to do something here - not familiar with Docker

ggerganov avatar Mar 19 '23 18:03 ggerganov

Would github.repository_owner / secrets.GITHUB_TOKEN work? (with the appropriate permissions, namely packages: write)

I think this should work, I changed it and the login at least went well. It would be necessary to test if we have the appropriate permissions during the push of the image.

@ggerganov can you authorize this PR? Ty!

bernatvadell avatar Mar 20 '23 15:03 bernatvadell

Seems reasonable to me but we can’t fully test until merging.

it's working! ty

bernatvadell avatar Mar 20 '23 17:03 bernatvadell