llama.cpp icon indicating copy to clipboard operation
llama.cpp copied to clipboard

Refactor gguf scripts to improve metadata handling

Open CISC opened this issue 10 months ago • 2 comments

I've had these changes locally for quite a while and more or less forgotten about them, it's high time to make a PR as it fixes a few issues (endianess check) as well as improving and deduplicating metadata handling/rendering across all scripts.

  • Added contents method to ReaderField class
  • Added endianess property to GGUFReader class

Supercedes #11905

CISC avatar Feb 16 '25 12:02 CISC

@CISC Can you confirm if this is ready to be merged?

ngxson avatar Feb 22 '25 10:02 ngxson

@ngxson Yes, it's ready, @compilade will add tests in another PR.

CISC avatar Feb 22 '25 11:02 CISC

@ngxson Resolved conflict with #12081 mind merging now? :)

CISC avatar Feb 26 '25 12:02 CISC

@compilade Thanks. :)

Remember to tag the new version, though maybe not before after your PR?

CISC avatar Feb 26 '25 13:02 CISC