httpin
httpin copied to clipboard
Expose core.ErrUnsupportedType so clients can use errors.Is()
Expose core.ErrUnsupportedType so clients can use errors.Is()
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5dca4c8
) 90.73% compared to head (e6be2b3
) 90.73%.
Additional details and impacted files
@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 90.73% 90.73%
=======================================
Files 33 33
Lines 1479 1479
=======================================
Hits 1342 1342
Misses 93 93
Partials 44 44
Flag | Coverage Δ | |
---|---|---|
unittests | 90.73% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ggicci - sorry had issues with my original PR: https://github.com/ggicci/httpin/pull/90 and coverage. Re-opened it and its now 🟢
Not sure if this is what you meant with:
Let's hide owl from the package users. We may create a name alias in httpin, e.g.
var ErrUnsupportedType = owl. ErrUnsupportedType
Let me know if you thought of it in a different way.
Thank you!
@ggicci - what are your thoughts about this change? Would be great for us if it could be merged and unblock us upgrading to the latest version.
Thanks!
It looks good to me. I will update ASAP.