Gaetano Giunta

Tested on pinba-php from Ubuntu Focal: ```php $t1 = pinba_timer_start(array('timerNr' => '1')); pinba_tag_set('yo', 'lo'); var_dump(count(pinba_timers_get())); // 1 var_dump(count(pinba_tags_get())); // 1 pinba_reset(); echo "--\n"; var_dump(count(pinba_timers_get())); // 1 !!! var_dump(count(pinba_tags_get())); // 0...

This causes a core dump: `$c = new PinbaClient(array());` tested with the extension version as found in Ubuntu 20.04

I tried to use it as such, and got this error message, which I found quite cryptic: Only "http:" protocol prefix is supported

Compatibility with Xdebug 3.0.0

1

In PHPUnit/Extensions/SeleniumCommon/prepend.php there is usage of the XDEBUG_CC_UNUSED constant, which has been removed from xdebug 3.0

- introduce namespaces - if we deliver the scripts as phar files, we might as well rely on Symfony console and Symfony process for child execution ?

pake_replace_regexp_to_dir fails if passed absolute file name and empty path

5

in line 293 of pake_function.php: $content = pake_read_file($src_dir.'/'.$file); we should prepend $src_dir . DIRECTORY_SPERARATOR only when $src_dir is not empty. Otherwise we get an error on windows: /C:/a/file/path

pake_replace_tokens( 'myfile' 'testdir', ... ) will fail, as it tries to replace in ./testdir/testdir/myfile - both on linux and windows

not possible to specify a custom pakefile.php in random directory

5

The code will only look for pakefile.php in current dir and parent dirs. It is possible to pass a "pakefile" option, but if that pakefile is in an unrelated dir...

add a pake task for sftp upload

3

This is, afaik, not currently supported by pake, and enough of a chore to merit some pake_function of its own (either that, or have it working via pake_write_file). From my...