webgl-fundamentals icon indicating copy to clipboard operation
webgl-fundamentals copied to clipboard

Minor copy-paste error "Bind the position buffer"

Open timdream opened this issue 4 years ago • 1 comments

There are multiple instances so the fix is more involved than using GitHub web interface. The comment in example says // Bind the position buffer. while the line right below binds texcoordBuffer (the texture buffer).

https://github.com/gfxfundamentals/webgl-fundamentals/blob/f6ec7b1ccf6e87d57eb44f5f4a026037f2bc0fa8/webgl/webgl-3d-textures-mips.html#L189

timdream avatar May 10 '20 23:05 timdream

Thanks. Yea there were a lot of them. Hopefully I found most of them and didn't mess things up.

https://github.com/gfxfundamentals/webgl-fundamentals/commit/c05f9112afd85a4fcd98ddcd0975a47e5ecafce5

greggman avatar May 11 '20 12:05 greggman