wgpu icon indicating copy to clipboard operation
wgpu copied to clipboard

Cause shader recompilation when changing shader constants in GLES

Open DerSchmale opened this issue 2 months ago • 5 comments

Description When using GLES as a backend, shaders would not recompile when changing push constants because they were not included in the program cache key. They are now, but the way the key field is generated could be improved.

Testing Using a simple shader choosing between two colours depending on an override constant.

Squash or Rebase?

Squash

DerSchmale avatar Oct 02 '25 12:10 DerSchmale

resolved: title was misleading, this not about push constants which shouldn't be part of shader compilation, but rather about shader constants

Wumpf avatar Oct 08 '25 15:10 Wumpf

@DerSchmale Any updates on this?

inner-daemons avatar Nov 30 '25 21:11 inner-daemons

Hey not yet, I've been swamped with work and haven't had the time to properly fix this. My apologies for this.

DerSchmale avatar Dec 01 '25 15:12 DerSchmale

Force of habit, changed it to to_ne_bytes.

DerSchmale avatar Dec 09 '25 16:12 DerSchmale

@jimblandy This should be good to look at again soon, its just a few lines

inner-daemons avatar Dec 10 '25 18:12 inner-daemons