wgpu icon indicating copy to clipboard operation
wgpu copied to clipboard

Converge dual-source blending with the WebGPU standard

Open ErichDonGubler opened this issue 1 year ago • 2 comments

https://www.w3.org/TR/webgpu/#dom-gpufeaturename-dual-source-blending

Firefox downstream tracking: bug 1924328

ErichDonGubler avatar Oct 11 '24 21:10 ErichDonGubler

We already support dual-source blending (https://github.com/gfx-rs/wgpu/issues/1804) but I think our validation is not 1:1 with the spec.

teoxoy avatar Oct 14 '24 10:10 teoxoy

@teoxoy: Ah, yes. I've renamed the issue to note that the scope is to converge with the spec.

ErichDonGubler avatar Oct 16 '24 14:10 ErichDonGubler

So the work here is:

  • Figure out what the spec says
  • Figure out what we're doing wrong, exactly

Teo suspects that our validation is too strict.

We are using the wrong names for things.

We don't have the enable implemented in the WGSL front end.

There are probably API bits too.

jimblandy avatar Nov 05 '24 17:11 jimblandy

Also, we're probably exposing this even when the feature isn't enabled.

jimblandy avatar Nov 05 '24 17:11 jimblandy

started looking into this because I need it for a toy project :) Expect my first Naga PR soon 😄

Wumpf avatar Feb 11 '25 23:02 Wumpf