wgpu icon indicating copy to clipboard operation
wgpu copied to clipboard
verified publisher icon gfx-rs

Update `cfg_aliases` in order to fix unexpected cfg condition warnings

Open Wumpf opened this issue 1 year ago • 2 comments

Connections

  • fixes https://github.com/gfx-rs/wgpu/issues/6347

Description (title)

Testing run cargo clippy with deleted rust-toolchain.toml file -> Turns out we do have one condition that needs to be ignored, wgpu_validate_locks (cc: @jimblandy )

Checklist

  • [x] Run cargo fmt.
  • [x] Run cargo clippy. If applicable, add:
    • [ ] --target wasm32-unknown-unknown
    • [ ] --target wasm32-unknown-emscripten
  • [ ] Run cargo xtask test to run tests.
  • [ ] Add change to CHANGELOG.md. See simple instructions inside file.

Wumpf avatar Oct 01 '24 08:10 Wumpf

I'm surprised this PR isn't running into the issues that motivated https://github.com/katharostech/cfg_aliases/pull/10, which is why I'd kept similar changes held back in #6105. 🤔 Will try out these changes locally.

ErichDonGubler avatar Oct 01 '24 10:10 ErichDonGubler

I've also observed the warning you cite in other projects which why I ignored it as well here, not thinking about it. Didn't get to the bottom of why this happens so far :(

Wumpf avatar Oct 02 '24 17:10 Wumpf

Discussed this in our 2024-11-13 maintainers' meeting agenda. Let's close in favor of https://github.com/gfx-rs/wgpu/pull/6105.

ErichDonGubler avatar Nov 13 '24 16:11 ErichDonGubler